-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTPv2 Support #917
Comments
That's a good idea! currently I don't have plans for that, but please feel free to contribute to this project and add this support. I can assist in guidance and code reviews |
Yes, I will try to add GTPv2 layer. |
@ArmanTulegenov do you know when you'll work on this? |
Let ne know any help required,I also like to contribute to this patch. Pls share PCAP file with GTPv2 |
@mmanoj please feel free to implement GTPv2, let me know if you need my help! Here are a few pcap files with GTPv2 I found online:
|
Thanks for the quick reply and support,sure I will looking in to it and update you.Currently I'm working on Radius 3GPP dictionary attributes decoding.I will check is it possible to open source with pcpp. |
Hi @seladb I'm working on initial work for GTPv2 message decoding, I will update you the progress,currently checking the core spec and protocol details. |
@seladb bool GtpV1Layer::isGTPv1(const uint8_t* data, size_t dataSize)
} |
above from 3_reattach.zip |
@mmanoj the idea is to look at the first 3 bits of the And in GTPv2 they will be set to Please let me know if that makes sense |
@seladb GTPv1: 00100000 = 20 in hex GTPv2: 01000000 =40 in Hex bool GtpV2Layer::isGTPv2(const uint8_t* data, size_t dataSize) return false; |
@mmanoj I think this is correct. The best way to make sure is to test with a real GTPv2 packet 😃 |
Thanks for the feedback.I will check and update you.Please share your email if possible to easy communication. |
Sure @mmanoj thank you! 🙏 You can always reach out to me at [email protected] |
can you advice, what will be the impact of below in example live capture app I observed low sleep leading to packet loss.Any idea? |
@mmanoj as mentioned in the comment below this line:
We sleep for 10 seconds in the main thread while the packet capture happens in another thread. Packet loss may happen if the capture thread cannot handle the volume of packets... |
Thanks for the feedback, when I shifted to blocking mode it's seems drop rate reduce to 0.02% . The PPS we tested around 5000 PPS. I dont think it's big amount as per the framework bench marked results. |
it's hard to analyze the packet loss without diving deeper into the details. In general blocking mode might be a bit faster because the packet capture happens on the main thread, while in non-blocking mode the main thread is running in parallel to the capture thread. But it's hard to say for sure if this is causing the difference in packet loss |
I want to start working on GTPv2. Would you please tell me what the current situation is with this issue? |
I think it is good to create a branch and share what you've done in GTPv2 so that I can continue and complete it. Thanks. |
GTPv2 support was added in #1634 |
Would be great to add GTPv2 Support. Do you have some plans around it?
The text was updated successfully, but these errors were encountered: