From 2c50e2e00abd0bf655b16cf18a31f431543992bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ege=20=C3=87etin?=
 <64282645+egecetin@users.noreply.github.com>
Date: Fri, 8 Nov 2024 12:03:16 +0300
Subject: [PATCH] Fix getRawPacketReadOnly() const-correctness #1573 (#1637)

* Fix getRawPacketReadOnly() const-correctness #1573

* fix kni

* fix clang-format

* Add ignore list for clang-tidy

* Revert "Add ignore list for clang-tidy"

This reverts commit dc3783ce2fcde5bbdb401112b2594a6275253cf3.
---
 Packet++/header/Packet.h | 2 +-
 Pcap++/src/KniDevice.cpp | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Packet++/header/Packet.h b/Packet++/header/Packet.h
index fac0a7203b..4e7760f678 100644
--- a/Packet++/header/Packet.h
+++ b/Packet++/header/Packet.h
@@ -178,7 +178,7 @@ namespace pcpp
 		 * Get a pointer to the Packet's RawPacket in a read-only manner
 		 * @return A pointer to the Packet's RawPacket
 		 */
-		RawPacket* getRawPacketReadOnly() const
+		const RawPacket* getRawPacketReadOnly() const
 		{
 			return m_RawPacket;
 		}
diff --git a/Pcap++/src/KniDevice.cpp b/Pcap++/src/KniDevice.cpp
index 0d144ec8b3..832bda282c 100644
--- a/Pcap++/src/KniDevice.cpp
+++ b/Pcap++/src/KniDevice.cpp
@@ -610,11 +610,10 @@ namespace pcpp
 		MBufRawPacket** allocated = CPP_VLA(MBufRawPacket*, arrLength);
 		uint16_t allocated_count = 0, packetsSent = 0;
 		MBufRawPacket* rawPacket;
-		RawPacket* raw_pkt;
 
 		for (uint16_t i = 0; i < arrLength; ++i)
 		{
-			raw_pkt = packetsArr[i]->getRawPacketReadOnly();
+			const auto* raw_pkt = packetsArr[i]->getRawPacketReadOnly();
 			uint8_t raw_type = raw_pkt->getObjectType();
 			if (raw_type != MBUFRAWPACKET_OBJECT_TYPE)
 			{