Fix websocket from_height #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1853 +/- ##
==========================================
- Coverage 61.64% 60.81% -0.84%
==========================================
Files 365 260 -105
Lines 26178 22869 -3309
==========================================
- Hits 16138 13908 -2230
+ Misses 8967 7976 -991
+ Partials 1073 985 -88
|
philipsu522
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
To fix #1850
There is a bug in how
fromHeightis set during the websocket handler loop. Specifically each iteration will only look at the latest height if we don't setfilter.FromBlockto the last height handled by the last iteration, so in the case where multiple heights have passed between two websocket iterations, events would be lost.Testing performed to validate your change
difficult to simulate latest height passing in unit test. Since this is an RPC-only change, we can apply it to the RPC node the bug reporter is using and see if the error is resolved