From fb368f693890f9d1610a6a3ae38cae40bf9f42c3 Mon Sep 17 00:00:00 2001 From: Colin Date: Fri, 25 Jan 2019 11:31:55 -0800 Subject: [PATCH] fix: apply strictNullCheck fix in analytics.js client (#46) This replicates the fix from: #43 in the `analytics.js` library, which was mistakenly left out of the previous PR. --- examples/gen-js/js/analytics/generated/index.d.ts | 2 +- examples/gen-js/ts/analytics/generated/index.d.ts | 2 +- src/commands/gen-js/typescript.ts | 2 +- tests/commands/gen-js/__snapshots__/index.d.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/gen-js/js/analytics/generated/index.d.ts b/examples/gen-js/js/analytics/generated/index.d.ts index 7232b400..766921bf 100644 --- a/examples/gen-js/js/analytics/generated/index.d.ts +++ b/examples/gen-js/js/analytics/generated/index.d.ts @@ -11,7 +11,7 @@ export interface SegmentOptions { AppsFlyer?: { appsFlyerId: string; }; - [key: string]: boolean | { [key: string]: string }; + [key: string]: boolean | { [key: string]: string } | undefined; }; } diff --git a/examples/gen-js/ts/analytics/generated/index.d.ts b/examples/gen-js/ts/analytics/generated/index.d.ts index 7232b400..766921bf 100644 --- a/examples/gen-js/ts/analytics/generated/index.d.ts +++ b/examples/gen-js/ts/analytics/generated/index.d.ts @@ -11,7 +11,7 @@ export interface SegmentOptions { AppsFlyer?: { appsFlyerId: string; }; - [key: string]: boolean | { [key: string]: string }; + [key: string]: boolean | { [key: string]: string } | undefined; }; } diff --git a/src/commands/gen-js/typescript.ts b/src/commands/gen-js/typescript.ts index 17e6ec39..01707372 100644 --- a/src/commands/gen-js/typescript.ts +++ b/src/commands/gen-js/typescript.ts @@ -100,7 +100,7 @@ export interface SegmentOptions { AppsFlyer?: { appsFlyerId: string } - [key: string]: boolean | { [key: string]: string } + [key: string]: boolean | { [key: string]: string } | undefined } }` diff --git a/tests/commands/gen-js/__snapshots__/index.d.ts b/tests/commands/gen-js/__snapshots__/index.d.ts index da709a47..49c275f3 100644 --- a/tests/commands/gen-js/__snapshots__/index.d.ts +++ b/tests/commands/gen-js/__snapshots__/index.d.ts @@ -11,7 +11,7 @@ export interface SegmentOptions { AppsFlyer?: { appsFlyerId: string; }; - [key: string]: boolean | { [key: string]: string }; + [key: string]: boolean | { [key: string]: string } | undefined; }; }