Skip to content

Commit 25ec16d

Browse files
Bump ui-box from 5.4.0 to 5.4.1 to fix primary link Tab (#1626)
Co-authored-by: Dan <[email protected]>
1 parent 135bbd6 commit 25ec16d

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"prop-types": "^15.6.2",
8080
"react-fast-compare": "^3.2.0",
8181
"react-transition-group": "^4.4.1",
82-
"ui-box": "^5.4.0"
82+
"ui-box": "^5.4.1"
8383
},
8484
"peerDependencies": {
8585
"react": "^16.8.0 || ^17.0.0 || ^18.0.0",

src/tabs/stories/index.stories.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class TabManager extends React.PureComponent {
3333
}
3434
}
3535

36+
const appearances = ['primary', 'secondary']
3637
const tabs = ['Traits', 'Event History', 'Identities']
3738

3839
storiesOf('tabs', module).add('Tab', () => (
@@ -99,13 +100,15 @@ storiesOf('tabs', module).add('Tab', () => (
99100
</StoryHeader>
100101

101102
<Box>
102-
<TabNavigation marginX={-4} marginBottom={16}>
103-
{tabs.map((tab, index) => (
104-
<Tab key={tab} is="a" href="#" id={tab} isSelected={index === 0}>
105-
{tab}
106-
</Tab>
107-
))}
108-
</TabNavigation>
103+
{appearances.map(appearance => (
104+
<TabNavigation key={appearance} marginX={-4} marginBottom={16}>
105+
{tabs.map((tab, index) => (
106+
<Tab key={tab} appearance={appearance} is="a" href="#" id={tab} isSelected={index === 0}>
107+
{tab}
108+
</Tab>
109+
))}
110+
</TabNavigation>
111+
))}
109112
</Box>
110113
</StorySection>
111114
<StorySection>

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14414,10 +14414,10 @@ [email protected]:
1441414414
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.4.tgz#a2a3d2756c079abda241d75f149df9d561091e78"
1441514415
integrity sha512-Uz+dTXYzxXXbsFpM86Wh3dKCxrQqUcVMxwU54orwlJjOpO3ao8L7j5lH+dWfTwgCwIuM9GQ2kvVotzYJMXTBZg==
1441614416

14417-
ui-box@^5.4.0:
14418-
version "5.4.0"
14419-
resolved "https://registry.yarnpkg.com/ui-box/-/ui-box-5.4.0.tgz#707c764fdf4be79cf2f50f356ca9583a491164ee"
14420-
integrity sha512-HuiJKUIOGW/I1VF7EgHl5/3OwywPdV5fwzsDOWfCGS/PORmXOyGetL3gJo9EQJZZZCkui9xf3a/UQhawA88yeQ==
14417+
ui-box@^5.4.1:
14418+
version "5.4.1"
14419+
resolved "https://registry.yarnpkg.com/ui-box/-/ui-box-5.4.1.tgz#34f497a143783a3513e850bd58379ac583e3f2fb"
14420+
integrity sha512-5p+b6kSh1q/bptvLANuAusyB/3fGIvnw8w6rSZNPHckQ8UdPfjIK4DvinmMXRKgdniOba22h8ypVqtkJ9zK/iQ==
1442114421
dependencies:
1442214422
"@emotion/hash" "^0.7.1"
1442314423
inline-style-prefixer "^5.0.4"

0 commit comments

Comments
 (0)