Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support flush on demand for node.js client #988

Closed
kim5566 opened this issue Nov 2, 2023 · 2 comments
Closed

support flush on demand for node.js client #988

kim5566 opened this issue Nov 2, 2023 · 2 comments

Comments

@kim5566
Copy link

kim5566 commented Nov 2, 2023

hey team,

i'm wondering if node.js client could support flush on demand like the classic one does before,

analytics.flush(function(err, batch){
  console.log('Flushed, and now this program can exit!');
});

instead of call .closeAndFlush() to stop collecting new events.

The use case i have is, i have set flushAt, for example, 100 and let batch processing events.

There's one particular time sensitive event, when it fired, i want to send immediately instead of waiting for the batch.

But i still want to keep collecting new events after flush.

@silesky
Copy link
Contributor

silesky commented Nov 2, 2023

Thanks @kim5566 for taking out an issue, we are looking at bringing this back -- see #822

@silesky
Copy link
Contributor

silesky commented Nov 2, 2023

Tracking this: #822 -- closed for consolidation purposes.

@silesky silesky closed this as completed Nov 2, 2023
@silesky silesky reopened this Nov 2, 2023
@silesky silesky closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants