Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warehouses control via Integration Object is always either true or false, never specific #1219

Closed
lucasassisrosa opened this issue Jan 30, 2025 · 2 comments

Comments

@lucasassisrosa
Copy link

lucasassisrosa commented Jan 30, 2025

According to https://segment.com/docs/connections/storage/warehouses/faq/#send-data-to-specific-warehouses, we should be able to control which Warehouses we want to use via Integrations Object. On latest version of @segmentanalytics-next (npm:next-1.77.0), if I provide the Integrations Object as:

  Warehouses: {
    all: false,
  }

The Segment event calls (track, page) show Warehouses: true in request payload instead. Same if I try to pass warehouseIds:

  (...)
  Warehouses: {
    all: false,
    warehouseIds: ["3dasf42dd"]
  }

The only Integrations Object config that's exactly passed in event calls are Warehouses: true or Warehouses: false.

Environment

Lib Version
Node 20.17.0
Segment 1.77.0
@silesky
Copy link
Contributor

silesky commented Jan 31, 2025

The Segment event calls (track, page) show Warehouses: true in request payload instead.

Hey @lucasassisrosa, I'm not able to reproduce this locally -- our library should proxy whatever you have in the integrations object.

I just did:

analytics.track(
        'foo',
        {},
        {
          integrations: {
            Warehouses: {
             all: false,
             warehouseIds: ["3dasf42dd"]
            }
          }
        }
      )

Locally (network calls):

Image

Segment Debugger:

Image

@silesky silesky closed this as completed Jan 31, 2025
@silesky silesky reopened this Jan 31, 2025
@silesky
Copy link
Contributor

silesky commented Jan 31, 2025

Closing, as unable to repro

@silesky silesky closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants