From 2c020f1c5269ab588b130b5bdee7ea028aa857d3 Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Thu, 9 Nov 2023 23:34:26 -0600 Subject: [PATCH] wip --- packages/generic-utils/src/emitter/emitter.ts | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/generic-utils/src/emitter/emitter.ts b/packages/generic-utils/src/emitter/emitter.ts index 57a86f3744..f600e15ae5 100644 --- a/packages/generic-utils/src/emitter/emitter.ts +++ b/packages/generic-utils/src/emitter/emitter.ts @@ -27,25 +27,25 @@ export class Emitter { constructor(options?: EmitterOptions) { this.maxListenersPerEvent = options?.maxListenersPerEvent ?? 10 } - private _callbacks: Partial = {} - private _warned = false + private callbacks: Partial = {} + private warned = false - private _warnIfPossibleMemoryLeak( + private warnIfPossibleMemoryLeak( event: EventName ) { - if (this._warned) { + if (this.warned) { return } if ( this.maxListenersPerEvent && - this._callbacks[event]!.length > this.maxListenersPerEvent + this.callbacks[event]!.length > this.maxListenersPerEvent ) { console.warn( `Event Emitter: Possible memory leak detected; ${String( event )} has exceeded ${this.maxListenersPerEvent} callbacks. ` ) - this._warned = true + this.warned = true } } @@ -53,11 +53,11 @@ export class Emitter { event: EventName, callback: (...args: Contract[EventName]) => void ): this { - if (!this._callbacks[event]) { - this._callbacks[event] = [callback] as Contract[EventName] + if (!this.callbacks[event]) { + this.callbacks[event] = [callback] as Contract[EventName] } else { - this._callbacks[event]!.push(callback) - this._warnIfPossibleMemoryLeak(event) + this.callbacks[event]!.push(callback) + this.warnIfPossibleMemoryLeak(event) } return this } @@ -79,9 +79,9 @@ export class Emitter { event: EventName, callback: (...args: Contract[EventName]) => void ): this { - const fns = this._callbacks[event] ?? [] + const fns = this.callbacks[event] ?? [] const without = fns.filter((fn) => fn !== callback) as Contract[EventName] - this._callbacks[event] = without + this.callbacks[event] = without return this } @@ -89,7 +89,7 @@ export class Emitter { event: EventName, ...args: Contract[EventName] ): this { - const callbacks = this._callbacks[event] ?? [] + const callbacks = this.callbacks[event] ?? [] callbacks.forEach((callback) => { callback.apply(this, args) })