Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow temporary sharing link for ISA tree #758

Open
wittigue opened this issue Oct 25, 2021 · 11 comments
Open

allow temporary sharing link for ISA tree #758

wittigue opened this issue Oct 25, 2021 · 11 comments
Assignees
Milestone

Comments

@wittigue
Copy link
Collaborator

Describe the bug
Currently only for single assets the creation of a temporary sharing link is allowed.

Expected behavior
Especially for reviewers of manuscripts and their corresponding supplementary data in FAIRDOMHub a temporary sharing link for the ISA tree would be necessary without making the data already public.

@wittigue
Copy link
Collaborator Author

wittigue commented Oct 5, 2022

now again several users complain about the problem of creating lots of temporary links for reviewers to have one ISA tree as supplementary data
--> could we push it?

@OlgaKrebs
Copy link
Collaborator

not sure, but would snapshot solve this problem?

@wittigue
Copy link
Collaborator Author

wittigue commented Oct 6, 2022

@OlgaKrebs snapshot is only possible if all assets are public which users don't like to do during the paper reviewing process

@OlgaKrebs
Copy link
Collaborator

I know, but I suggest that we can may be change it (why not?) - allow snapshots for "internal use" before publishing/getting DOI. cause procedure is = 1. create snapshot 2. get DOI
I would rather go this way (temporary link for snapshot) than allow temporary link for whole ISA tree as error prawn

@floradanna
Copy link
Collaborator

I think the procedure currently is: 1. Make items public in SEEK, 2. Make a snapshot, 3. get DOI.

The problematic step for researchers seems to be the number 1 (making items public in seek), if I understand correctly what Ulrike is saying.

@stuzart
Copy link
Member

stuzart commented Oct 6, 2022

You can create a snapshot with items still private, they just won't be included in the snapshot

@stuzart
Copy link
Member

stuzart commented Oct 6, 2022

@OlgaKrebs
Copy link
Collaborator

BTW: just checked, I can create snap shot for my Investigation containing non-public elements https://fairdomhub.org/investigations/1/ , it means I went through the whole procedure to the end .... but no new snapshot created (just 2 olds) . Bug? will check it and report extra

@OlgaKrebs
Copy link
Collaborator

OlgaKrebs commented Oct 6, 2022

https://docs.seek4science.org/images/user-guide/snapshotting_2.png

exactly, what I assumed. Stuart, does it mean, that creating temporary link for (certain) snap shot could work?

@floradanna
Copy link
Collaborator

@stuzart Yes, but if items are not included in the snapshot, they cannot be shared/made accessible to reviewers via that snapshot, correct?

Researchers are asking for a way to share an ISA-tree of private items with non-registered seek users via 1 link for the entire ISA, without having to make those items public in seek (if I understand correctly what Ulrike is asking).

@OlgaKrebs
Copy link
Collaborator

OlgaKrebs commented Oct 6, 2022

@stuzart Yes, but if items are not included in the snapshot, they cannot be shared/made accessible to reviewers via that snapshot, correct?

Researchers are asking for a way to share an ISA-tree of private items with non-registered seek users via 1 link for the entire ISA, without having to make those items public in seek (if I understand correctly what Ulrike is asking).

Yes, Flora - since now it is not possible - what Ulrike is asking for- I try to suggest /discuss a possible way of implementation. One possible way I suggested ( and asked Stuart about this) is to allow making snap shot from (part of) Investigation with non-public assets and this snap shot will be not available for e.g. DOI creating. And this snapshot can be used as a target for temporary link (without having all the further assets associated to this Investigation later on be a part of the link). Of course, you are free to suggest different way of implementation. I think, we have agreed on this " temporary link is a 100% user responsibility , user/owner creates link, user/owner sends it to external people". But if link is to Investigation level, what is about other users who can upload/register/link to the same Investigation new assets - without knowing "this Investigation is available via external link to someone else....". I see this way of implementation as a dangerous one cause taking responsibility for data sharing from user to us.

@stuzart stuzart added this to the v1.14.0 milestone Feb 8, 2023
@whomingbird whomingbird self-assigned this May 3, 2023
@stuzart stuzart modified the milestones: v1.14.0, v1.15.0 Jul 5, 2023
@stuzart stuzart modified the milestones: v1.15.0, 1.15.1 Mar 19, 2024
@stuzart stuzart modified the milestones: 1.15.1, 1.17.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants