From 77fbb6a457a3442672a9e7c33358ba111c2fc2a0 Mon Sep 17 00:00:00 2001 From: Adam Skoufis Date: Fri, 25 Aug 2023 14:53:09 +1000 Subject: [PATCH] Add `.storybook/main.js` to git and lint ignore files --- packages/sku/lib/configure.js | 4 ++++ tests/configure.test.ts | 12 ++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/packages/sku/lib/configure.js b/packages/sku/lib/configure.js index 4c0539af3..01516d9ea 100755 --- a/packages/sku/lib/configure.js +++ b/packages/sku/lib/configure.js @@ -28,16 +28,20 @@ const writeFileToCWD = async (fileName, content, { banner = true } = {}) => { await writeFile(outPath, contentStr); }; +const storybookMainConfig = '.storybook/main.js'; + module.exports = async () => { // Ignore webpack bundle report output const gitIgnorePatterns = [ addSep(bundleReportFolder), addSep(coverageFolder), + storybookMainConfig, ]; const lintIgnorePatterns = [ addSep(bundleReportFolder), addSep(coverageFolder), '*.less.d.ts', + storybookMainConfig, ]; // Ignore webpack target directories diff --git a/tests/configure.test.ts b/tests/configure.test.ts index 53b5ff3a7..12bb29fa6 100644 --- a/tests/configure.test.ts +++ b/tests/configure.test.ts @@ -77,9 +77,10 @@ describe('configure', () => { it(`should generate \`.gitignore\``, async () => { const ignoreContents = await readIgnore(appFolder, '.gitignore'); - expect(ignoreContents.length).toEqual(7); + expect(ignoreContents.length).toEqual(8); expect(ignoreContents).toContain(`.eslintrc`); expect(ignoreContents).toContain(`.prettierrc`); + expect(ignoreContents).toContain(`.storybook/main.js`); expect(ignoreContents).toContain(`${defaultTargetDir}/`); expect(ignoreContents).toContain(`${defaultStorybookTargetDir}/`); expect(ignoreContents).toContain(`${bundleReportFolder}/`); @@ -90,8 +91,9 @@ describe('configure', () => { ['.eslintignore', '.prettierignore'].forEach((ignore) => it(`should generate \`${ignore}\``, async () => { const ignoreContents = await readIgnore(appFolder, ignore); - expect(ignoreContents.length).toEqual(5); + expect(ignoreContents.length).toEqual(6); expect(ignoreContents).toContain('*.less.d.ts'); + expect(ignoreContents).toContain(`.storybook/main.js`); expect(ignoreContents).toContain(`${defaultTargetDir}/`); expect(ignoreContents).toContain(`${bundleReportFolder}/`); expect(ignoreContents).toContain(`${coverageFolder}/`); @@ -137,10 +139,11 @@ describe('configure', () => { it(`should generate \`.gitignore\``, async () => { const ignoreContents = await readIgnore(appFolderTS, '.gitignore'); - expect(ignoreContents.length).toEqual(7); + expect(ignoreContents.length).toEqual(8); expect(ignoreContents).toContain(`.eslintrc`); expect(ignoreContents).toContain(`.prettierrc`); expect(ignoreContents).toContain(`tsconfig.json`); + expect(ignoreContents).toContain(`.storybook/main.js`); expect(ignoreContents).toContain(`${skuConfig.target}/`); expect(ignoreContents).toContain(`${skuConfig.storybookTarget}/`); expect(ignoreContents).toContain(`${bundleReportFolder}/`); @@ -150,8 +153,9 @@ describe('configure', () => { ['.eslintignore', '.prettierignore'].forEach((ignore) => it(`should generate \`${ignore}\``, async () => { const ignoreContents = await readIgnore(appFolderTS, ignore); - expect(ignoreContents.length).toEqual(5); + expect(ignoreContents.length).toEqual(6); expect(ignoreContents).toContain('*.less.d.ts'); + expect(ignoreContents).toContain(`.storybook/main.js`); expect(ignoreContents).toContain(`${skuConfig.target}/`); expect(ignoreContents).toContain(`${skuConfig.storybookTarget}/`); expect(ignoreContents).toContain(`${bundleReportFolder}/`);