Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Loki in CI #4

Open
72636c opened this issue Jun 4, 2020 · 1 comment
Open

Run Loki in CI #4

72636c opened this issue Jun 4, 2020 · 1 comment

Comments

@72636c
Copy link
Member

72636c commented Jun 4, 2020

We’ve found that running Loki against a static Storybook render leads to significant flakiness.

There are probably two options here:

  • Try to figure out the root cause (seemingly Loki not waiting for the page to properly load) and contribute an upstream patch
  • Get the live Storybook server running in a separate Docker Compose container, and run Loki against that container
@72636c
Copy link
Member Author

72636c commented Jun 4, 2020

Old Buildkite config:

steps:
  - commands:
      - yarn build-storybook
      - yarn test:loki:ci
    plugins:
      - docker#v3.5.0:
          environment:
            - BUILDKITE_BUILD_PATH=/var/lib/buildkite/builds
          propagate-environment: true
          volumes:
            - /usr/local/bin/buildkite-agent:/usr/local/bin/buildkite-agent
            - /var/lib/buildkite/builds:/var/lib/buildkite/builds
            - /var/run/docker.sock:/var/run/docker.sock
            - /workdir/dist-storybook-tmp:/workdir/dist-storybook-tmp
            - /workdir/node_modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant