Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morph relations are not supported #38

Open
mkalam-alami opened this issue Aug 23, 2017 · 1 comment
Open

Morph relations are not supported #38

mkalam-alami opened this issue Aug 23, 2017 · 1 comment

Comments

@mkalam-alami
Copy link

It seems like the constructed delete queries only match the IDs, while with morph relations you'd have to check both the ID & type columns. This leads to unwanted deletes.

I realized that the hard way, maybe it would be worth documenting this limitation and/or skipping the data (like you seem to do with belongsToMany) until this type of relation is supported.

@nunorafaelrocha
Copy link
Collaborator

Hi @mkalam-alami, thanks for the issue. Maybe I can encourage you to submit a Pull Request? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants