Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore appears to restart every time the activity is opened #815

Open
mattfbacon opened this issue Dec 12, 2024 · 10 comments
Open

Restore appears to restart every time the activity is opened #815

mattfbacon opened this issue Dec 12, 2024 · 10 comments
Labels
invalid needs info Requires more information from reporter

Comments

@mattfbacon
Copy link

While the Restore is active, if I do something else and then return to the activity, the progress bar starts back at the beginning and I see the same apps being installed one-by-one again.

@mattfbacon
Copy link
Author

The half-restored state for installing missing apps disappears as well, which is annoying because we are supposed to be using other app stores to install these apps at this stage.

@grote
Copy link
Collaborator

grote commented Dec 12, 2024

What version of Seedvault are you using? Can you share a screenshot of the About screen please?

@grote grote added the needs info Requires more information from reporter label Dec 12, 2024
@grote
Copy link
Collaborator

grote commented Dec 12, 2024

Do you see a notification for restore while restore is running? After restore has restarted, can you leave the restore flow and export logs for us to analyze? I imagine, you can easily reproduce the "restart" behavior? Helpful would also be a screencast, so we understand exactly what is happening here.

@mattfbacon
Copy link
Author

Version 14-3.3

I closed the app by pressing the square button (it goes to the home screen, recents has always been super buggy, that's just how it is). Then I go back to seedvault and the progress resets after a bit.

out.webm

@mattfbacon
Copy link
Author

mattfbacon commented Dec 12, 2024

There is also some weirdness because grapheneos embeds Seedvault into settings, i.e., it has no entry in the Apps menu (it's a system app). I wanted to check there if notifications are disabled for Seedvault because I didn't see any progress notification for the Restore.

@grote
Copy link
Collaborator

grote commented Dec 12, 2024

Ok version 14-3.3 is super outdated. This version doesn't support restore after setup wizard (where you can leave the app). If Graphene enabled this for this version, it is on them. Calyx didn't support restore after SUW for this Seedvault version.

Are you sure you are on latest Graphene release?

@grote grote added the invalid label Dec 12, 2024
@mattfbacon
Copy link
Author

I am on the 14 tag of GrapheneOS which is supposedly the development branch for the Pixel 5a.

@grote
Copy link
Collaborator

grote commented Dec 12, 2024

Are you self-building the OS then? Maybe try pull from android14 branch of this repo into packages/apps/Seedvault.

@mattfbacon
Copy link
Author

This is the source: https://github.com/GrapheneOS/platform_external_seedvault/tree/14
Looks like the last common commit is 695c33e.
I don't want to be try directly from this repo because I think some of the GrapheneOS patches are necessary but I could try rebasing their patches on top of this repo.

@grote
Copy link
Collaborator

grote commented Dec 14, 2024

Yes try rebasing. The commits touching Android.bp files are probably needed. Could also cherry-pick those in case rebase fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid needs info Requires more information from reporter
Projects
None yet
Development

No branches or pull requests

2 participants