Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion]: Verifying package and resource properties #830

Open
martonvago opened this issue Oct 31, 2024 · 0 comments
Open

[discussion]: Verifying package and resource properties #830

martonvago opened this issue Oct 31, 2024 · 0 comments

Comments

@martonvago
Copy link
Contributor

This is just to keep track of some questions about how we verify package and resource properties. This is not to say that big changes are necessary, only to make sure that we consider them fully.

lwjohnst86 pushed a commit that referenced this issue Nov 3, 2024
…to the `Properties` classes (#832)

## Description

NB this is a stacked PR merging to #808 

This PR changes the behaviour of `verify_properties_are_wellformed()`
based on the changes to the `Properties` classes in #808

This work was done in collaboration with @martonvago 🌷 It's not pretty,
but it gets the work done for now.
During this, we talked about #830 and how we think not using
`frictionless-py` could simplify the work here as well, since the
`validate()`function keeps surprising us by not working as we expect it
to.

<!-- Select quick/in-depth as necessary -->
This PR needs an in-depth review.

## Checklist

- [X] Added or updated tests
- [X] Tests passed locally
- [X] Linted and formatted code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant