You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is just to keep track of some questions about how we verify package and resource properties. This is not to say that big changes are necessary, only to make sure that we consider them fully.
How will the move to a new library for validation/verification affect the way we verify package and resource properties? Do we want to keep using frictionless-py for verification (currently in verify_properties_are_well_formed)? Related to [discussion]: Consider other packages for doing validation work #826.
What forms can a *Properties object take (e.g. any *Properties instance, default *Properties instance, compact_dict representation of the instance) and when do we want to consider each of these as correct?
The text was updated successfully, but these errors were encountered:
…to the `Properties` classes (#832)
## Description
NB this is a stacked PR merging to #808
This PR changes the behaviour of `verify_properties_are_wellformed()`
based on the changes to the `Properties` classes in #808
This work was done in collaboration with @martonvago 🌷 It's not pretty,
but it gets the work done for now.
During this, we talked about #830 and how we think not using
`frictionless-py` could simplify the work here as well, since the
`validate()`function keeps surprising us by not working as we expect it
to.
<!-- Select quick/in-depth as necessary -->
This PR needs an in-depth review.
## Checklist
- [X] Added or updated tests
- [X] Tests passed locally
- [X] Linted and formatted code
This is just to keep track of some questions about how we verify package and resource properties. This is not to say that big changes are necessary, only to make sure that we consider them fully.
frictionless-py
for verification (currently inverify_properties_are_well_formed
)? Related to [discussion]: Consider other packages for doing validation work #826.*Properties
classes affect the way we verify package and resource properties? Related to feat: ✨ updateProperties
classes with default method and change behaviour ofcompact_dict
#808.*Properties
object take (e.g. any*Properties
instance, default*Properties
instance,compact_dict
representation of the instance) and when do we want to consider each of these as correct?The text was updated successfully, but these errors were encountered: