This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Add Dockerfile #238
Closed
Add Dockerfile #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuagl
reviewed
Jun 10, 2019
Dockerfile
Outdated
| # Validate Gosec tar.gz file checksum | ||
| RUN echo "490c2a0434b2b9cbb2f4c5031eafe228023f1ac41b36dddd757bff9e1de76a2b ./gosec_2.0.0_linux_amd64.tar.gz" | sha256sum -c - | ||
|
|
||
| # Install all nessery tools to unzip the gosec tar.gz file |
ericwb
suggested changes
Jun 24, 2019
| # Copy precaution in the root directory | ||
| COPY . precaution | ||
|
|
||
| # Setup a work directory for all comamnds below |
There was a problem hiding this comment.
Suggested change
| # Setup a work directory for all comamnds below | |
| # Setup a working directory for all commands below |
joshuagl
added
the
work-in-progress
As we discussed before #227 there are many benefits to creating a Docker image which will be run on Heroku. That way we would be free from the limitations provided by Heroku and we would be able to use Go modules. Also, if one day we decide to move Precaution on another hosting platform it will be really easy. We won't need the ".profile" file anymore because we would install Gosec in our Dockerfile as all other dependencies. Signed-off-by: Martin Vrachev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed before #227
there are many benefits to creating a Docker image which will be run
on Heroku. That way we would be free from the limitations provided
by Heroku and we would be able to use Go modules.
Also, if one day we decide to move Precaution on another
hosting platform it will be really easy.
We won't need the ".profile" file anymore because we would install
Gosec in our Dockerfile as all other dependencies.
Closes: #227
Signed-off-by: Martin Vrachev [email protected]