Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch trust regions should use latest query point #782

Closed
khurram-ghani opened this issue Aug 25, 2023 · 1 comment
Closed

Batch trust regions should use latest query point #782

khurram-ghani opened this issue Aug 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@khurram-ghani
Copy link
Collaborator

Describe the bug
The new batch trust region algorithms use the full dataset to determine the best point in each region. This is a hack, since the best point may have been queried by a different region in the previous iteration. Each region should only use its own query point from the previous iteration.

To reproduce
Previous discussion on this issue is in this PR.
@khurram-ghani khurram-ghani added the bug Something isn't working label Aug 25, 2023
@khurram-ghani khurram-ghani mentioned this issue Dec 12, 2023
Merged
3 tasks
@khurram-ghani
Copy link
Collaborator Author

This was fixed in #788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@khurram-ghani