Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG 14 support not published #2032

Open
aotaduy opened this issue Apr 28, 2023 · 15 comments
Open

NG 14 support not published #2032

aotaduy opened this issue Apr 28, 2023 · 15 comments

Comments

@aotaduy
Copy link

aotaduy commented Apr 28, 2023

Hi
We are users of this package but we need to upgrade to angular 14.
Looks like the required changes are merged but not published to npm.
Could you please publish the latest changes to npm creating a new version so we can update this dependency ?

imagen

imagen

imagen

Regards!

@Juliete
Copy link

Juliete commented May 10, 2023

I need it too, I'm doing my npm install with --force

@jncalderon
Copy link

@sebholstein I need it too :)

@ghost
Copy link

ghost commented May 13, 2023

Same for me :/

@keithcoughtrey
Copy link

And another

@broomfn
Copy link

broomfn commented May 30, 2023

+1

@jncalderon
Copy link

@sebholstein need help ? here are people interest in add support to NG14, your project is very valuable and helpful

@madmacc
Copy link

madmacc commented Jun 12, 2023

I just upgraded to Angular 16. Any plans for that?
I'm looking at changing to https://www.npmjs.com/package/@angular/google-maps or https://github.com/ng-maps/ng-maps
Pros and cons vs waiting?

@DaSchTour
Copy link
Contributor

@jncalderon if you would like to help I would like to invite to help with https://github.com/ng-maps/ng-maps
I started it as an organization to have a fork of AGM that can be maintained by more than one person and that will have a workflow to publish updates not depending on one developer.

@aotaduy
Copy link
Author

aotaduy commented Oct 30, 2023

Hi Everyone,
We have created a fork of this repo (https://github.com/grupo-san-cristobal/angular-google-maps/tree/develop) to publish a full compatible version, with Angular 14 support, we are going to also publish an Angular 15 compatible version in the near future.

We dont plan on changing any API from the original project, only angular migrations and bug fixing.

We are using this package in some commercial projects and plan to support it long term. Our idea is to contribute back to the original repo, but we tried to contact @sebholstein with no luck yet.

We have created the repo and published the Angular 14 packages here:

https://www.npmjs.com/package/@grupo-san-cristobal/agm-core
https://www.npmjs.com/package/@grupo-san-cristobal/agm-drawing
https://www.npmjs.com/package/@grupo-san-cristobal/agm-markerclusterer
https://www.npmjs.com/package/@grupo-san-cristobal/agm-snazzy-info-window

Feel free to use them we have tested core and drawing that are the ones we use in our applications, but the others should work fine.

@DaSchTour
Copy link
Contributor

I'm really curious how this is a good idea to create numerous forks. While maintaining one was already hard as you can see by this discussion and you already struggle to keep yours up to date with latest angular.

@broomfn
Copy link

broomfn commented Oct 31, 2023

Thanks for stepping up @aotaduy, in the end we removed this package in favour of one with a larger user base and better supported.

@DaSchTour
Copy link
Contributor

Thanks for stepping up @aotaduy, in the end we removed this package in favour of one with a larger user base and better supported.

Just out of curiosity, would let us know which package you switch to, which has a larger user base and better support?

@broomfn
Copy link

broomfn commented Oct 31, 2023

Thanks for stepping up @aotaduy, in the end we removed this package in favour of one with a larger user base and better supported.

Just out of curiosity, would let us know which package you switch to, which has a larger user base and better support?

Sure, I'm not sure how useful it will be to you, I suppose it depends what kind of project you have, but we switched to https://www.npmjs.com/package/@capacitor/google-maps for use in an Ionic App.

@madmacc
Copy link

madmacc commented Oct 31, 2023

Curious why people would not use https://www.npmjs.com/package/@angular/google-maps now that it is an official Angular component?
I'm planning on moving to this.

@madmacc
Copy link

madmacc commented Oct 31, 2023

Thanks for stepping up @aotaduy, in the end we removed this package in favour of one with a larger user base and better supported.

Just out of curiosity, would let us know which package you switch to, which has a larger user base and better support?

Sure, I'm not sure how useful it will be to you, I suppose it depends what kind of project you have, but we switched to https://www.npmjs.com/package/@capacitor/google-maps for use in an Ionic App.

I will also use this for my Ionic app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants