Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaration of methods from Dispatcher class must be compatible with Symfony EventDispatcherInterface interface #70

Closed
LucasLaurens opened this issue Jan 29, 2024 · 3 comments

Comments

@LucasLaurens
Copy link

LucasLaurens commented Jan 29, 2024

Context

I updated composer with composer update.
I ran the command php ./vendor/bin/phpstan analyse -c phpstan.neon to analyse my code. I received an error on this Sebdesign\SM\Event\Dispatcher file. The methods no longer correspond to the Symfony update.

Note

This depreciation comes with the new version of Symfony e.g. symfony/event-dispatcher:7.0.2.

Capture d’écran 2024-01-29 à 13 59 13

@LucasLaurens LucasLaurens changed the title Declaration of addListener and addSubscriber Dispatcher must be compatible with Symfony EventDispatcherInterface interface Declaration of methods from Dispatcher class must be compatible with Symfony EventDispatcherInterface interface Jan 29, 2024
@LucasLaurens
Copy link
Author

LucasLaurens commented Jan 29, 2024

I could create a PULL REQUEST to see if there are any other similar issues. However, I don't have the permission yet.

@ABartelt
Copy link

I think PR #69 addresses this issue already 👍

@LucasLaurens
Copy link
Author

I think PR #69 addresses this issue already 👍

You're absolutely right. That's exactly right. I hadn't seen that much for myself. Thank you. So I'll wait for the PR to be validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants