Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear "Usage" instruction #60

Open
AndreySurzhan opened this issue Feb 13, 2018 · 6 comments
Open

Not clear "Usage" instruction #60

AndreySurzhan opened this issue Feb 13, 2018 · 6 comments

Comments

@AndreySurzhan
Copy link

Hi all,
I would like to sorry in advance if it is just me not able to understand the instruction.
I tried several things and it seems git-pylint-commit-hook is just not triggered on git commit

My settings:

  • git-pylint-commit-hook==2.2.2
  • Python 3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 07:18:10) [MSC v.1900 32 bit (Intel)] on win32
  • no custom pylint configs

Test case#1
I tried to follow that instruction:
README.md
When I do commit hook is not triggered and commit is created successfully

Test case#2
I tried to follow that instruction:
http://git-pylint-commit-hook.readthedocs.io/en/latest/usage.html#usage
When I do commit I see the following
.git/hooks/pre-commit: line 2: git-pylint-commit-hook: command not found

Please let know what I am doing wrong

@volviq
Copy link
Contributor

volviq commented Mar 10, 2018

.git/hooks/pre-commit: line 2: git-pylint-commit-hook: command not found
If you execute git-pylint-commit-hook and which git-pylint-commit-hook - what does it tell you?

@AndreySurzhan
Copy link
Author

@volviq
Unfortunately I am developing under Windows :) so which doesn't exist
but where git-pylint-commit-hook shows me the following:
%project_root_path%\venv\Scripts\git-pylint-commit-hook

@AndreySurzhan
Copy link
Author

(venv) %project_root%>git-pylint-commit-hook
'git-pylint-commit-hook' is not recognized as an internal or external command,
operable program or batch file.

@AndreySurzhan
Copy link
Author

I haven't tested that under Unix (mac or linux)

@volviq
Copy link
Contributor

volviq commented Mar 15, 2018

So if you execute git-pylint-commit-hook on your normal Windows shell, would it then pick up the binary? If not, you have to possibly add it to your path. I wouldn't even have expected, that this works on Windows at all (I'm not the maintainer, so don't take my guesses as a truth).

@AndreySurzhan
Copy link
Author

AndreySurzhan commented Mar 15, 2018

@volviq thanks for your response.
I've been using pre-commit lib with pylint hook
That is workaround for me.
I thought that repo's being maintained that is why I didn't bother fixing that in the first place.
If I have time I will try to fix that issue and do PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants