New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use capitals in Bash, don't use *.sh #45

Open

avlapp opened this issue Dec 19, 2021 · 0 comments

avlapp commented Dec 19, 2021

A bit nitpicking here:

Bash scripts shouldn't use *.sh as extension

Variables in bash should be lowercase. Uppercase are for environment, internal and shell variables.

So DATA should be lowercase in the install.sh script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment