Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think I found a bug at JCloudStorageModule #25

Open
felipegutierrez opened this issue Jun 3, 2015 · 0 comments
Open

I think I found a bug at JCloudStorageModule #25

felipegutierrez opened this issue Jun 3, 2015 · 0 comments

Comments

@felipegutierrez
Copy link

Hi,

I was executing Virtual Machines at jscsi and I got some bug at the JCloudStorageModule. The method storeBucket has to verify if the bucketId has different byte array.

https://github.com/sebastiangraf/jSCSI/blob/master/bundles/target/src/main/java/org/jscsi/target/storage/JCloudsStorageModule.java#L261

I change the IF for this:

if ((lastIndexWritten != pBucketId && lastBlobWritten != null) || (lastIndexWritten == pBucketId && !Arrays.equals(lastBlobWritten, pData) && lastBlobWritten != null)) {

I don't know if you agree. Maybe I could commit this on your code if you agree.

Thanks,
Felipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant