Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getContext Precedence #855

Closed
korgon opened this issue Aug 2, 2023 · 0 comments · Fixed by #889 or #893
Closed

getContext Precedence #855

korgon opened this issue Aug 2, 2023 · 0 comments · Fixed by #889 or #893
Assignees
@korgon @dkonieczek
Labels
type: bug Something isn't working

Comments

@korgon
Copy link
Contributor

korgon commented Aug 2, 2023

Seems the order of the getContext attributes vs. script variables is incorrect...
The variable value probably ought to supercede the attribute value.

https://github.com/searchspring/snap/blob/v0.46.0/packages/snap-toolbox/src/getContext/getContext.ts#L41-L57

Need to see what kind of impact switching these around might have.
@korgon korgon changed the title getContext Precedence getContext Precedence Aug 2, 2023
@korgon korgon added the type: bug Something isn't working label Aug 3, 2023
@dkonieczek dkonieczek linked a pull request Sep 14, 2023 that will close this issue
refactor: change order of attributes and script variables #889
Merged
@korgon korgon mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korgon korgon

@dkonieczek dkonieczek

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@korgon @dkonieczek