Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon SubComponent Props #1087

Closed
korgon opened this issue Jun 27, 2024 · 1 comment · Fixed by #1104
Closed

Icon SubComponent Props #1087

korgon opened this issue Jun 27, 2024 · 1 comment · Fixed by #1104
Assignees
@chrisFrazier77
Labels
type: feature New functionality
Milestone
Snap Templates

Comments

@korgon
Copy link
Contributor

korgon commented Jun 27, 2024

Components that have an icon prop that is a string should also alternatively support using IconProps.
@korgon korgon added this to the Snap Templates milestone Jun 27, 2024
@korgon korgon added the type: feature New functionality label Jun 27, 2024
@chrisFrazier77 chrisFrazier77 self-assigned this Jul 3, 2024
@chrisFrazier77 chrisFrazier77 linked a pull request Jul 11, 2024 that will close this issue
allow any icon prop to also pass partial iconProps #1104
Merged
@korgon
Copy link
Contributor Author

korgon commented Jul 16, 2024

Merged into templates branch.

@korgon korgon closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisFrazier77 chrisFrazier77

Labels
type: feature New functionality
Projects
None yet
Milestone
Snap Templates
Development

Successfully merging a pull request may close this issue.

allow any icon prop to also pass partial iconProps searchspring/snap
2 participants
@korgon @chrisFrazier77