fix(CoC): 单项结果文本被格式化两次, 属性表达式文本赋值顺序 #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
老师提交辛苦。因为涉及到实现逻辑更改。老师自己测试过是否解决问题吗？ |
Xiangze-Li
reviewed
Oct 14, 2024
kenichiLyon
pushed a commit
to kenichiLyon/sealdice-core
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VarSetValueStr(mctx, "$t结果文本", DiceFormatTmpl(mctx, "COC:检定_单项结果文本"))（在判断是否为多轮检定前后都为 $t结果文本 赋值一次）, 会导致检定_单项结果文本额外初始化，造成计数或豹语多次执行的问题，因不确定是否有其他影响先注释掉多轮检定前的初始化，fix [Bug]: 检定指令ra中单项结果重复计算 #1036ra指令的变量赋值顺序 #549，将属性表达式文本的赋值也放到判定结果计算/生成前。fix 可以支持.ra特定属性时回复特定语句吗？ #1055