Wrong generic type for findAsync method

[dremchee]

nedb/index.d.ts

Line 91 in 68279cc

): Nedb.Cursor<T[]>;

I think it should be like this Document<T>[] instead of T[]

[arantes555]

@dremchee I believe Nedb.Cursor<T> extends Promise<Document<T>>, so it should already be the case once awaited, or am I wrong ?

[dremchee]

@dremchee I believe Nedb.Cursor<T> extends Promise<Document<T>>, so it should already be the case once awaited, or am I wrong ?

I mean the findAsync method, which should return an array
For example sandbox https://codesandbox.io/p/sandbox/nedb-generic-type-pr8lvv?file=%2Fsrc%2Findex.ts%3A13%2C1

[RobMayer]

I just encountered this. @dremchee is right.

// CURRENT BEHAVIOUR
const cursor = db.findAsync({ id: { $in: someArray}}(; // Cursor<T[]>
const result = await cursor.execAsync;() // Document<T[]>
result[0]._id // Should be a valid property but isn't showing up
result._id // Shouldn't be a valid property but is showing up

// EXPECTED BEHAVIOUR
const cursor = db.findAsync({ id: { $in: someArray}}(; // Cursor<T[]>
const result = await cursor.execAsync;() // Document<T>[]

result[0]._id // each row has an _id, does it now?