Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI actions should build with clang also #21

Open
axel-h opened this issue Feb 12, 2022 · 4 comments
Open

CI actions should build with clang also #21

axel-h opened this issue Feb 12, 2022 · 4 comments
Labels
CI continuous integration and testing enhancement

Comments

@axel-h
Copy link
Member

axel-h commented Feb 12, 2022

CI actions should build with clang also besides just gcc and benchmaks should run with both binaries. Building with clang is expected to improve code quality, because clang raises more warnings. Large discrepancies in the benchmark results can indicate that the benchmark either has a strong compiler dependency or its implementation has issues.

Building with clang also seems rather trivial, running both binaries will be more work.

@lsf37
Copy link
Member

lsf37 commented Feb 12, 2022

That does sound reasonable. @kent-mcleod any concerns on adding a build and run with clang for all benchmarks? It'll take more machine time, but it could be informative.

@lsf37
Copy link
Member

lsf37 commented Feb 12, 2022

Then again, the x86 runs each take 50 min, and if we want comparable numbers they need to run on the same machine, so we would be blowing the time out to 100 min.

@axel-h
Copy link
Member Author

axel-h commented Feb 12, 2022

If the concern is about hardware resources, it could be a topic for the budget planning.

@lsf37
Copy link
Member

lsf37 commented Feb 12, 2022

If we want gcc/clang to be comparable, should it not be the exact same machine? In that case it doesn't matter if we buy more. We do have more x86 boards, but I'm not sure they are the same configurations. @wom-bat might be able to confirm. x86 machines should be easy to add, I think, if that helps.

Another way to look at this would be to see if all x86 benchmarks are actually needed/informative. What currently exists is what has accumulated and not necessarily designed to be the optimal set for CI.

@axel-h axel-h added CI continuous integration and testing enhancement labels Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration and testing enhancement
Projects
None yet
Development

No branches or pull requests

2 participants