Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elfloader: factor out check_hash() #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Mar 22, 2023

Cleaning up the code, so it becomes a bit more modular. Moving this out comes handy for further refactoring.
This also allows running the hash check on the image before accessing any other data from it.

The feature is enabled when compiling with -DElfloaderHashInstructions="hash_sha". Is anybody using this actually?

@axel-h axel-h added the cleanup label Mar 22, 2023
@axel-h axel-h marked this pull request as draft March 22, 2023 12:29
@axel-h axel-h force-pushed the patch-axel-14 branch 2 times, most recently from 459807e to 49d9301 Compare March 28, 2023 13:43
@axel-h axel-h marked this pull request as ready for review May 4, 2023 16:39
@axel-h axel-h force-pushed the patch-axel-14 branch 2 times, most recently from 0b5d821 to 422286d Compare January 15, 2024 13:16
@axel-h axel-h added the hw-build enable all sel4test hardware builds label Feb 23, 2024
@axel-h axel-h force-pushed the patch-axel-14 branch 2 times, most recently from b5de26e to 66670d4 Compare February 23, 2024 19:10
@axel-h axel-h force-pushed the patch-axel-14 branch 4 times, most recently from 594de26 to 44bd2e0 Compare March 6, 2024 14:27
@axel-h
Copy link
Member Author

axel-h commented Mar 6, 2024

Any chance to get this merged?

This also allows running the hash check on the image before accessing
any other data from it.

Signed-off-by: Axel Heider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup hw-build enable all sel4test hardware builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant