Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use System locale for Defaults #178

Open
flywire opened this issue Jun 12, 2021 · 2 comments
Open

Use System locale for Defaults #178

flywire opened this issue Jun 12, 2021 · 2 comments

Comments

@flywire
Copy link
Contributor

flywire commented Jun 12, 2021

Should use system locale for all monetary defaults rather than just 3-letter International currency symbol (#174) with rest from https://github.com/sdementen/piecash/blob/master/piecash/core/currency_ISO.py

@sdementen
Copy link
Owner

Sometimes you may need to create a currency that is not in your locale for foreign transactions. Would you advise here to play with locale to get these currencies too? Isn't it more complex than just giving the iso of the currency?
Via the locale, can you recover the information that is in the currency_iso.py file?

@flywire
Copy link
Contributor Author

flywire commented Jun 13, 2021

I tested locale in on online python box and it generated exceptions because locale wasn't available. I'd expect setting locale as default would use all system settings. If an actual currency is specified or recovery after an exception then use currency_iso.py file.

Yes it is more complex. First priority would be just roll out 3-letter International currency symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants