Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternator's user managed serving certificate is not supported #2248

Open
rzetelskik opened this issue Dec 9, 2024 · 3 comments
Open

Alternator's user managed serving certificate is not supported #2248

rzetelskik opened this issue Dec 9, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@rzetelskik
Copy link
Member

rzetelskik commented Dec 9, 2024

I've noticed that although our API has an option for user managed serving certificate for alternator

UserManagedOptions *UserManagedTLSCertificateOptions `json:"userManagedOptions,omitempty"`
, the certs are only set up for operator managed type:

if sdc.Spec.ScyllaDB.AlternatorOptions != nil &&

if sdc.Spec.ScyllaDB.AlternatorOptions != nil {

We should set up certificate generation for user managed type as well.

/kind bug

@scylla-operator-bot scylla-operator-bot bot added kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 9, 2024
@tnozicka
Copy link
Member

tnozicka commented Dec 9, 2024

We should set up certificate generation for user managed type as well.

User managed kind of means we don't generate the certs but only configure the given one.

@rzetelskik
Copy link
Member Author

but only configure the given one

which we don't, although yes, it manifests in resource creation, not in cert generation

@tnozicka
Copy link
Member

tnozicka commented Dec 9, 2024

which we don't

I guess it works with the same name only today but we should fix plumbing it through

@tnozicka tnozicka added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 9, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants