Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable compaction during restore #3953

Closed
Tracked by #3706
Michal-Leszczynski opened this issue Aug 5, 2024 · 0 comments · Fixed by #4060
Closed
Tracked by #3706

Disable compaction during restore #3953

Michal-Leszczynski opened this issue Aug 5, 2024 · 0 comments · Fixed by #4060
Assignees
@Michal-Leszczynski
Labels
enhancement New feature or request restore
Milestone
3.4

Comments

@Michal-Leszczynski
Copy link
Collaborator

As observed in benchmarks, restore (mainly l&s) slows down noticeably when the compaction is running.
The compactions should be disabled during restore and re-enabled afterwards (similar to tombstone_gc).
image
image
@Michal-Leszczynski Michal-Leszczynski added enhancement New feature or request restore labels Aug 5, 2024
@Michal-Leszczynski Michal-Leszczynski self-assigned this Aug 5, 2024
@Michal-Leszczynski Michal-Leszczynski mentioned this issue Aug 5, 2024
Closed
Michal-Leszczynski added a commit that referenced this issue Aug 7, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
29f1433 
Fixes #3953
@Michal-Leszczynski Michal-Leszczynski mentioned this issue Aug 7, 2024
Closed
Michal-Leszczynski added a commit that referenced this issue Aug 13, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
23c0f15 
Fixes #3953
Michal-Leszczynski added a commit that referenced this issue Aug 14, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
e0ace1e 
Fixes #3953
Michal-Leszczynski added a commit that referenced this issue Aug 20, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
cefd5d9 
Fixes #3953
Michal-Leszczynski added a commit that referenced this issue Aug 20, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
d46dc97 
Fixes #3953
Michal-Leszczynski added a commit that referenced this issue Aug 20, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
b4ef256 
Fixes #3953
Michal-Leszczynski added a commit that referenced this issue Sep 2, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
6e75e54 
Fixes #3953
Michal-Leszczynski added a commit that referenced this issue Sep 2, 2024
@Michal-Leszczynski
feat(restore): disable compaction during restore
948adde 
Fixes #3953
@karol-kokoszka karol-kokoszka added this to the 3.3.3 milestone Sep 9, 2024
@Michal-Leszczynski Michal-Leszczynski mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michal-Leszczynski Michal-Leszczynski

Labels
enhancement New feature or request restore
Projects
None yet
Milestone
3.4
2 participants
@karol-kokoszka @Michal-Leszczynski