Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Issue on page Specification #4009

Closed
regevran opened this issue Aug 29, 2024 · 2 comments · Fixed by #4076
Closed

docs: Issue on page Specification #4009

regevran opened this issue Aug 29, 2024 · 2 comments · Fixed by #4076
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@regevran
Copy link

I would like to report an issue on page https://manager.docs.scylladb.com/branch-3.3/backup/specification

Problem

  1. meta, schema and sst exact directory structure is not clear.

  2. It seems that the path for schema is incorrect (no schema directory):
    meta/cluster/<cluster ID>/task_<task ID>_tag_<snapshot tag>_schema_with_internals.json.gz

Suggest a fix

Make both the line and the drawing of the directories explicitly start from root (/).
e.g:
/meta/schema/cluster/<cluster ID>/task_<task ID>_tag_<snapshot tag>_schema_with_internals.json.gz

@Michal-Leszczynski
Copy link
Collaborator

Thanks for reporting!
The schema path is indeed incorrect, it should be /schema/cluster/<cluster ID>/task_<task ID>_tag_<snapshot tag>_schema_with_internals.json.gz. I can also change paths to start from root.

@Michal-Leszczynski Michal-Leszczynski added the documentation Improvements or additions to documentation label Sep 2, 2024
@Michal-Leszczynski Michal-Leszczynski self-assigned this Sep 2, 2024
@regevran
Copy link
Author

regevran commented Sep 2, 2024

I can also change paths to start from root.
I think this is the best approach when possible.
If it is not hard-coded from root, and there is a prefix, then this prefix should be mentioned after the root -
e.g. /{prefix}/meta/scema.....

Michal-Leszczynski added a commit that referenced this issue Oct 23, 2024
Previously all run/task properties of post-restore repair progress
were taken directly from the restore progress.
This included things like start/end time, properties,
status, cause and others. It resulted in misleading progress display.
This commit fixes that by deliberately leaving out, inheriting,
or setting interesting repair progress fields.

Fixes #4009
Michal-Leszczynski added a commit that referenced this issue Oct 23, 2024
Previously all run/task properties of post-restore repair progress
were taken directly from the restore progress.
This included things like start/end time, properties,
status, cause and others. It resulted in misleading progress display.
This commit fixes that by deliberately leaving out, inheriting,
or setting interesting repair progress fields.

Fixes #4009
Michal-Leszczynski added a commit that referenced this issue Oct 26, 2024
Previously all run/task properties of post-restore repair progress
were taken directly from the restore progress.
This included things like start/end time, properties,
status, cause and others. It resulted in misleading progress display.
This commit fixes that by deliberately leaving out, inheriting,
or setting interesting repair progress fields.

Fixes #4009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants