Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScyllaNode methods that invoke scylla-sstable should take care of disabling compaction #538

Open
denesb opened this issue Dec 8, 2023 · 1 comment

Comments

@denesb
Copy link
Contributor

denesb commented Dec 8, 2023

Using scylla-sstable on sstables, runs the risk of the sstable disappearing by the time scylla-sstable tries to read it, because ScyllaDB decides to compact it at the wrong moment. Scylla-sstable also reads the schema-table stables, which runs the same risk. For this reason tests using scylla-sstable indirectly are often found to be flaky, occasinally failing because an sstable was pulled from under the feet of scylla-sstable.
We currently rely on the callers to disable compaction on the system_schema keyspace and the examined user keyspace for the scope of invoking scylla-sstable. Callers however don't always remember to do this and we keep finding cases where this is missing.

I think the best place to do this would be in scylla-ccm, inside the methods which invoke scylla-sstable. Users would not have to to remember to disable compaction, they would automatically be safe.

@denesb
Copy link
Contributor Author

denesb commented Dec 8, 2023

@tchaikov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant