Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New info log print during cluster shutdown, is breaking dtest usages of c-s #430

Open
fruch opened this issue Jan 29, 2025 · 4 comments
Open

Comments

@fruch
Copy link

fruch commented Jan 29, 2025

seems like recently this log line was added during shutdown of the cluster:

INFO  [main] 2025-01-29 02:03:18,734 Metadata.java:164 - Unregistered tablet map's event listener.

dtest has logic that is looking for the END print in c-s output, and this line "stands" in the way
and lots of the dtest gating tests failed cause of this silly thing

Ref: https://github.com/scylladb/scylla-dtest/pull/5538

@Lorak-mmk
Copy link

Its not really something to fix on the driver side, right? Printing a log is not a bug.

@dkropachev
Copy link
Collaborator

Its not really something to fix on the driver side, right? Printing a log is not a bug.

+1, dtest should not be that fragile, driver does lot's ot async stuff after cluster is being closed, it can throw in anything.
Probably what we should do, we should separate logs from output, throwing logs into stderr so that dtest and sct could have a way to separate between them.
But it should be done on c-s side.

@fruch
Copy link
Author

fruch commented Jan 30, 2025

Also this print is meaningless and doesn't need to be info, seems like it's a leftover from some debugging session

@dkropachev
Copy link
Collaborator

Also this print is meaningless and doesn't need to be info, seems like it's a leftover from some debugging session

True, I have created pr to lower it down to debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants