Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extent calculation doesn't account for radius of Points #693

Open
timtreis opened this issue Aug 28, 2024 · 1 comment
Open

Extent calculation doesn't account for radius of Points #693

timtreis opened this issue Aug 28, 2024 · 1 comment
Labels

Comments

@timtreis
Copy link
Member

Just fixed scverse/spatialdata-plot#334 and noticed that the extent calculation does not account for the radius of points. In the first version of this picture we calculated this within spatialdata-plot but that has since moved upstream. It's realistically not super noticeable if these are small, but f.e. in our test case it stands out:

image

Can be mitigated through the pad_extent parameter in sdata.pl.show(), but figured I'd report anyway.

@LucaMarconato
Copy link
Member

That's strange; you are using spatialdata.get_extent() right? In the API the radius is taken into account in the extent calculation:

bounds["minx"] -= circles["radius"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants