Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster implementation available for vectorize() #634

Open
LucaMarconato opened this issue Jul 11, 2024 · 4 comments
Open

Faster implementation available for vectorize() #634

LucaMarconato opened this issue Jul 11, 2024 · 4 comments
Labels
enhancement ✨ New feature or request

Comments

@LucaMarconato
Copy link
Member

During the Ghent Hackathon (BioHackrXiv here) a faster implementation for vectorize() has been developed by @hey2homie: https://github.com/saeyslab/VIB_Hackathon_June_2024/blob/main/polygons/polygons_test.ipynb.

The implementation also fixes #583, but relies on opencv, which is a heavy dependency.

Still, we should see if that code could help improving the performance.

@LucaMarconato
Copy link
Member Author

@hey2homie I won't have the time to check your approach soon, but if you think that the same approach could be used without using opencv and are willing to open a PR, your contribution would be very welcome 😊

@hey2homie
Copy link

@LucaMarconato, thanks for reaching out! Was a bit busy lately to follow-up on this. There were some minor issues in the code from the hackathon, but I've already fixed them. I will work a bit more on this to polish and submit PR.

By the way, the speed bust most like coming from not using chunking with dask arrays but simply using numpy as both opencv and skimage have almost identical performance. So, abandoning opencv in favor to skimage wouldn't be a problem!

@LucaMarconato
Copy link
Member Author

Thank you for the explanation, and thank you in advance for the PR; it is very appreciated!

@giovp
Copy link
Member

giovp commented Sep 6, 2024

is this related to #560 ?

@giovp giovp added the enhancement ✨ New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants