Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotImplementedError: Multiscale images are not implemented yet #70

Closed
duongvtt96 opened this issue Jan 12, 2024 · 2 comments
Closed

NotImplementedError: Multiscale images are not implemented yet #70

duongvtt96 opened this issue Jan 12, 2024 · 2 comments

Comments

@duongvtt96
Copy link

Hi, I tried to run the densenet.ipynb notebook, but faced an error when creating ImageTilesDataset: NotImplementedError: Multiscale images are not implemented yet.
The original code is
dataset = ImageTilesDataset( sdata=merged, regions_to_images={"cell_circles": "CytAssist_FFPE_Human_Breast_Cancer_full_image"}, tile_dim_in_units=3 * xenium_circles_diameter, tile_dim_in_pixels=32, target_coordinate_system="aligned", transform=my_transform, )
and was modified to:
dataset = ImageTilesDataset( sdata=merged, regions_to_images={"cell_circles": "CytAssist_FFPE_Human_Breast_Cancer_full_image"}, tile_dim_in_units=3 * xenium_circles_diameter, #tile_dim_in_pixels=32, #target_coordinate_system="aligned", regions_to_coordinate_systems={"cell_circles": "aligned"}, transform=my_transform, )
with spatialdata version=0.0.16.dev24+ga5336d8 installed from GitHub.

Do you have any suggestions for this issue? Thank you.

@LucaMarconato
Copy link
Member

Thanks for reporting, we tested the notebook before making a release so it should work on the latest version of spatialdata and we are aware that it currently doesn't work on the main branch. In fact we improved the ImageTilesDataset class with this PR scverse/spatialdata#299 but we haven't updated the notebook yet.

I will do this before the next release, but also I will keep you updated here as soon as it is ready, so that you don't have to wait for the next release.

@LucaMarconato
Copy link
Member

@duongvtt96, with scverse/spatialdata#439 merged, the new ImageTilesDataset class now work also for multiscale images and multiscale labels. I will update the example notebook for the 0.1.0 release but you can already use the code if you install spatialdata from the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants