Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'max_iter_harmony' arguement into external.pp.harmony_integrate #3480

Closed
shihsama opened this issue Feb 24, 2025 · 2 comments
Closed
Labels
Triage 🩺 This issue needs to be triaged by a maintainer

Comments

@shihsama
Copy link

What kind of feature would you like to request?

Additional function parameters / changed functionality / changed defaults?

Please describe your wishes

Hi,
So glad to see that harmony is used in scanpy. As a former R harmony user, I found external.pp.harmony_integrate would stop after the max iteration of 10. Then I checked the original funtion run_harmony(). The default value of max_iter_harmony was 10. Therefore, could you please pass the 'max_iter_harmony’ arguement to external.pp.harmony_integrate() for users to fit their personal datasets?
Thanks for your attention!

@shihsama shihsama added the Triage 🩺 This issue needs to be triaged by a maintainer label Feb 24, 2025
@maltekuehl
Copy link

This should already be possible, as you can pass any keyword arguments to harmony_integrate that will be passed on to run_harmony, see: https://github.com/scverse/scanpy/blob/1.11.0/src/scanpy/external/pp/_harmony_integrate.py#L57

@shihsama
Copy link
Author

shihsama commented Mar 5, 2025

This should already be possible, as you can pass any keyword arguments to harmony_integrate that will be passed on to run_harmony, see: https://github.com/scverse/scanpy/blob/1.11.0/src/scanpy/external/pp/_harmony_integrate.py#L57

Thank you friend! It works

@shihsama shihsama closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage 🩺 This issue needs to be triaged by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants