Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release regex #1667

Closed
flying-sheep opened this issue Sep 5, 2024 · 2 comments
Closed

Release regex #1667

flying-sheep opened this issue Sep 5, 2024 · 2 comments

Comments

@flying-sheep
Copy link
Member

flying-sheep commented Sep 5, 2024

@ilan-gold

we should probably relax this more to accept all of PEP 440:

FULL_VERSION_RE = re.compile(r"^(\d+)\.(\d+)\.(\d+)(?:(\.dev.*)|(rc.*))?$")

Maybe we can just use packaging.version.parse instead of a custom regex?

The reson this check is there is so the directive doesn’t try to include the fragment files. The fragment files are probably not legal PEP 440 versions, but we need to check

Copy link

github-actions bot commented Nov 5, 2024

This issue has been automatically marked as stale because it has not had recent activity.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@flying-sheep
Copy link
Member Author

moved to theislab/scanpydoc#181

@flying-sheep flying-sheep closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant