Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete TransferEventArgs #603

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Remove obsolete TransferEventArgs #603

merged 1 commit into from
Jul 4, 2023

Conversation

echevrier
Copy link
Contributor

TransferEventArgs was needed when we checked the transition with events (wait_for_event). No longer used
Closes #506

@echevrier echevrier added the E0-silent Will not be mentioned in the release label Jun 30, 2023
@echevrier echevrier requested a review from Niederb June 30, 2023 09:56
Niederb
Niederb approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@echevrier echevrier merged commit ebdf081 into master Jul 4, 2023
37 of 38 checks passed
@echevrier echevrier deleted the ec/transfer_event_ex branch July 4, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niederb Niederb Niederb approved these changes

Assignees
No one assigned
Labels
E0-silent Will not be mentioned in the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate: Is the TransferEventArgs in the example obsolete?
2 participants
@echevrier @Niederb