Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions and blocking next() #638

Closed
Niederb opened this issue Aug 2, 2023 · 1 comment
Closed

Subscriptions and blocking next() #638

Niederb opened this issue Aug 2, 2023 · 1 comment
Labels
F7-enhancement Enhances an already existing functionality Q3-substantial

Comments

@Niederb
Copy link
Contributor

Niederb commented Aug 2, 2023

Currently subscriptions are blocking in the sync case. See here:

block_on(self.inner.next()).map(|result| result.map_err(|e| Error::Client(Box::new(e))))
}

Check whether it is possible to "break" this blocking by calling unsubscribe() and if yes also allow the user to use this to cancel calls to next() that are stuck.
See this previous discussion: #635 (comment)

@haerdib haerdib added F7-enhancement Enhances an already existing functionality Q3-substantial labels Nov 14, 2023
@haerdib
Copy link
Contributor

haerdib commented Dec 21, 2023

With #692 this issue is now obsolete and can be closed

@haerdib haerdib closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F7-enhancement Enhances an already existing functionality Q3-substantial
Projects
None yet
Development

No branches or pull requests

2 participants