Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example to show usage of submit_and_watch_extrinsic_until_without_event #627

Open
haerdib opened this issue Jul 24, 2023 · 0 comments
Open
Labels
Q3-substantial Z3-example Add or fix an example

Comments

@haerdib
Copy link
Contributor

haerdib commented Jul 24, 2023

Create an example to show the usage of this function (if there's a reasonable example use case)

According to #615 (comment):

Not showing any examples is just a way of forcing the user not to use it. Is that really what we want?
I'm not sure the comments are clear enough. Because we're talking about an error when an extrinsic has failed on the chain, and not an event, the user may think that submit_and_watch_extrinsic_until_without_event informs her when an extrinsic fails on the chain. Without studying the code, they may miss this point.
Maybe add an example check_extrinsic_without_events similar to check_extrinsic_events? We could do it in another issue. Maybe I'm too picky, so it's up to you to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Q3-substantial Z3-example Add or fix an example
Projects
None yet
Development

No branches or pull requests

1 participant