Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Investigate) Move call definition into extrinsic traits #441

Open
haerdib opened this issue Jan 19, 2023 · 0 comments
Open

(Investigate) Move call definition into extrinsic traits #441

haerdib opened this issue Jan 19, 2023 · 0 comments
Labels
F5-refactor Does not change any functionality of the code Q3-substantial

Comments

@haerdib
Copy link
Contributor

haerdib commented Jan 19, 2023

According to #434 (comment):

I'm wondering if we couldn't also "move" these types into the trait?
Do you think it's overkill or is there a specific reason not to do it?

One should look into if it makes sense to move the call definitions

/// Call for a balance transfer.
pub type TransferCall<Address, Balance> = (CallIndex, Address, Compact<Balance>);
/// Call to the balance of an account.
pub type SetBalanceCall<Address, Balance> =
(CallIndex, Address, Compact<Balance>, Compact<Balance>);

as a trait type. Should be a simplification, not something that makes things more compilacated.

@haerdib haerdib added F5-refactor Does not change any functionality of the code Q0-trivial labels Jan 19, 2023
@haerdib haerdib changed the title (Investigate) Move call definition into traits (Investigate) Move call definition into extrinsic traits Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F5-refactor Does not change any functionality of the code Q3-substantial
Projects
None yet
Development

No branches or pull requests

1 participant