Duplicate access token in url

[ghost]

While debugging a Guzzle request I noticed the access token appears twice in the url. It is set in line 39 and line 55:

ocular/src/Scrutinizer/Ocular/Command/CodeCoverage/UploadCommand.php

Line 39 in 4ed78dd

'access_token' => $input->getOption('access-token'),

ocular/src/Scrutinizer/Ocular/Command/CodeCoverage/UploadCommand.php

Line 55 in 4ed78dd

'repositories/'.$repositoryName.'/data/code-coverage{?access_token}',

One should probably be removed?

[andreasciamanna]

Same issue here.

I couldn't find the time to properly debug this, but in \Guzzle\Http\Client::createRequest at line #184, ($url = Url::factory($this->getBaseUrl())->combine($this->expandTemplate($uri, $templateVars));), the $url variable is set as such:

Guzzle\Http\Url::__set_state(array(
   'scheme' => 'https',
   'host' => 'scrutinizer-ci.com',
   'port' => NULL,
   'username' => NULL,
   'password' => NULL,
   'path' => 'XXXXXXXXXXXXX',
   'fragment' => NULL,
   'query' => 
  Guzzle\Http\QueryString::__set_state(array(
     'fieldSeparator' => '&',
     'valueSeparator' => '=',
     'urlEncode' => 'RFC 3986',
     'aggregator' => NULL,
     'data' => 
    array (
      'access_token' => 
      array (
        0 => '37CBD44EDADBAC15B1AAEE4CB517168BB8D43901CF3F8E30417E5E9C35AE12CA',
        1 => '37CBD44EDADBAC15B1AAEE4CB517168BB8D43901CF3F8E30417E5E9C35AE12CA',
      ),
    ),
  )),
))

[schmittjoh]

The duplicate access token should generally not hurt, but it is indeed something that is unnecessary.

Did you receive another error which lead you to debugging this?

[andreasciamanna]

No errors, actually. I confirm this issue is not hurting.