Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests don't link up when specifying commit by command line #16

Open
markguinn opened this issue Oct 30, 2015 · 1 comment
Open

Comments

@markguinn
Copy link

When explicitly specifying the commit hash like so:

wget https://scrutinizer-ci.com/ocular.phar
php ocular.phar code-coverage:upload -v --format=php-clover --repository=g/$TRAVIS_REPO_SLUG --revision=$TRAVIS_COMMIT ~/builds/ss/shop/coverage.xml

The coverage links up fine for branch pushes, but never lands in Scrutinizer for pull requests. Is this a bug or is there a different syntax to use for PR's?

@schmittjoh
Copy link
Member

For pull-requests, the commit actually refers to the merge commit. It's a temporary version where your source branch has been merged into the target branch since this is temporary and does not become part of the repository until you actually merge the pull-request, the revision on Scrutinizer might be different than that on Travis.

To circumvent this problem, you can pass both parents of the merge via --parent. This is what the command does when you do not explicitly pass parameters, and allows us to link the data to the correct inspection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants