Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp_hide_post_Public::query_posts_join() expected to be a reference, value given #7

Open
skorasaurus opened this issue Nov 9, 2017 · 1 comment

Comments

@skorasaurus
Copy link

skorasaurus commented Nov 9, 2017

After upgrading my dev instance to php 7.1 (specifically 7.1.11-1+ubuntu14.04.1+deb.sury.org+1; it was previously running 7.0); I receive the following error in my query monitor plugin:
Parameter 2 to wp_hide_post_Public::query_posts_join() expected to be a reference, value given
This happens at wp-includes/class-wp-hook.php:298 and a call stack:

` wp()
wp-blog-header.php:16

WP->main()
wp-includes/functions.php:955

WP->query_posts()
wp-includes/class-wp.php:735

WP_Query->query()
wp-includes/class-wp.php:617

WP_Query->get_posts()
wp-includes/class-wp-query.php:3248

apply_filters_ref_array('posts_join_paged')
wp-includes/class-wp-query.php:2554`
@halfer
Copy link

halfer commented Apr 8, 2018

I found this issue too. Oddly, it seems to have been fixed in 2.0.11 release on 20 Aug 2017, but the change for this is not in master. Also, the latest release over on the WP site is 2.0.10.

Having had a look at the changeset for 2.0.11, I wonder if someone did a complete rebase of the project? The changes are not at all mergeable, and are massive for a minor patch-level update.

Update

My bad - although the 2.0.11 release notes say "Fixed a bug where parameter to a filter was not being passed by reference", the necessary change is not in there. I will use a fork for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants