Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enqueue an empty JS file #5

Open
mallardduck opened this issue Oct 12, 2017 · 2 comments
Open

Don't enqueue an empty JS file #5

mallardduck opened this issue Oct 12, 2017 · 2 comments

Comments

@mallardduck
Copy link

Could you comment this out until there's something in the file to execute? As it stands now the file seems to be just a placeholder and has no executable code. As such there's no reason to enqueue this script since it's just adding another resource to sites that use it and isn't providing any functionality.

wp_enqueue_script($this->wp_hide_post, plugin_dir_url(__FILE__) . 'js/wp-hide-post-public.js', array('jquery'), $this->version, false);

@northnose
Copy link

Bumping

@scriptburn - Looks like there hasn't been much activity on this project lately, but it's still a very useful piece of code that could use some love. I'm happy to submit a pull request if you're willing to review/accept/push to wordpress.org.

@northnose
Copy link

Ah, whoops, looks like there is already a 3-mo-old pull request out for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants