Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftLint: Fix trailing comma throughout codebase #421

Closed
2 tasks done
andrewtavis opened this issue May 5, 2024 · 3 comments
Closed
2 tasks done

SwiftLint: Fix trailing comma throughout codebase #421

andrewtavis opened this issue May 5, 2024 · 3 comments
Assignees
@mostazomarc
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 5, 2024 •
edited
Loading

Terms

Description

This issue would be to remove trailing_comma as a disabled rule from .swiftlint.yaml and fix all errors for it in the codebase.

We'd know that this is successful if our SwiftLint pull request workflow passes on the pull request for the change :)

Contribution

This would be a great good first issue for someone wanting to start with Scribe-iOS development. Happy to support! 😊
@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 5, 2024
@andrewtavis andrewtavis changed the title SwiftLint: Fox trailing comma throughout codebase SwiftLint: Fix trailing comma throughout codebase May 5, 2024
mostazomarc added a commit to mostazomarc/Scribe-iOS that referenced this issue May 5, 2024
@mostazomarc
scribe-org#421 removed 'trailing_comma' from disabled rules in .swift…
49adfd0 
…lint.yaml
mostazomarc added a commit to mostazomarc/Scribe-iOS that referenced this issue May 5, 2024
@mostazomarc
scribe-org#421 ran swiftlint --fix to solve 'trailing_comma' errors
3374f9e
@mostazomarc mostazomarc mentioned this issue May 5, 2024
Merged
1 task
mostazomarc added a commit to mostazomarc/Scribe-iOS that referenced this issue May 5, 2024
@mostazomarc
scribe-org#421 added path options in pr_swiftlint workflow
f29c3e7
mostazomarc added a commit to mostazomarc/Scribe-iOS that referenced this issue May 6, 2024
@mostazomarc
scribe-org#421 Renamed swiftlint files to .yml
2878914
andrewtavis added a commit that referenced this issue May 14, 2024
@andrewtavis
Merge pull request #422 from mostazomarc/421-fix-trailing-comma
12537ce 
#421 fix trailing comma
@andrewtavis
Copy link
Member Author

Closed via #422 🚀 Thanks, @mostazomarc! Would be very happy to work with you on more issues like this 😊

@mostazomarc
Copy link
Contributor

Thank you, @andrewtavis! I'm glad I could contribute. I'd be keen to work on more issues like this in the future. Let me know if there's anything else I can assist with! 😊

@andrewtavis
Copy link
Member Author

Hey @mostazomarc 👋 Tons of new SwiftLint issues just made 😊 Feel free to write in one and I'll assign you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostazomarc mostazomarc

Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @mostazomarc