Word being replaced in emoji prediction

[andrewtavis]

Terms

• I have searched all open bug reports
• I agree to follow Scribe-iOS' Code of Conduct

Behavior

Emoji autosuggestions were added via #51, but one lingering issue is that at times the word is being replaced rather than the emoji being added after it (similar to how an emoji autocompletion would replace the word, but this is not the desired behavior). An instance of this is when typing the word Kuss in German, meaning “kiss”, where when pushing either of the emoji suggestions the word is replaced by the emoji instead of the emoji being inserted after.

This is likely a conflict with the features implemented for #250 and #256 :)

Device type

iPhone and iPad

Versions

I’m assuming all versions

[ArslanYM]

Is this issue fixed?

[andrewtavis]

Hey @ArslanYM! Thanks for your interest in Scribe :) It’s yet to be fixed and I haven’t started working on it. Let me know if you have interest and I’d be happy to assign it to you 😊

[andrewtavis]

@ArslanYM, I'm going to work on #277 today and think it makes sense if I work on this as well as I'll be testing this behavior :) There are a few more new issues that I made today that could also be of interest 😊

[andrewtavis]

Obviously let me know if you have some code written though in the last few hours and you're welcome to commit it!

[andrewtavis]

Note: specifically there's an issue where the word that would be displayed to a user in case the space autosuggest insertion was wrong is the word itself, but then it was the only option so the space should function normally in this case. allowUndo is possibly being triggered when it shouldn't, or currentPrefix is being incorrectly assigned and clearPrefixFromTextFieldProxy() is being triggered.

[ArslanYM]

No I haven't

[andrewtavis]

Great :) Will send along a PR for this shortly 😊

[andrewtavis]

Closed in 97c0afb 😊