Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Danish keyboard #133

Open
4 of 11 tasks
andrewtavis opened this issue Feb 12, 2022 · 7 comments
Open
4 of 11 tasks

Add Danish keyboard #133

andrewtavis opened this issue Feb 12, 2022 · 7 comments
Labels
-priority- High priority help wanted Extra attention is needed new keyboard Adding a new language keyboard

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Feb 12, 2022

Terms

Language support

Danish has lots of available language data on Wikidata, and for this reason should be included as soon as possible. As with Swedish, there is common and neutral in Danish, and verb conjugation also seems to be fairly simple such that the 2x2 display would be being used. This is likely going to be the most effort for this issue in terms of finding which tenses should be displayed where. There also seems to be issues with verb conjugations being labeled the same as in scribe-org/Scribe-Data#6, so those can be dropped for now with hopefully little effect to the available data.

Contribution

I'd be happy to work on this, and it may be focussed on in a future release :)

What's needed

  • A Danish directory added to Keyboards/LanguageKeyboards that includes a DanishKeyboardViewController.swift file
  • Danish language keyboard values and logic added to DAInterfaceVariables.swift in the above directory
  • Danish language keyboard commands added to DACommandVariables.swift in the above directory
  • Fine tuning the WDQS queries found in Scribe-Data/Data/Danish
  • Writing formatting Python scripts and adding them to Scribe-Data/Data/Danish
  • Add Danish keyboard specific logic to KeyboardViewController.swift
  • Setting up alternate key functions if there are keys that have them that aren't already implemented
  • Adding all the formatted JSON data to a Data directory in the new directory and updating the data table in the readme
@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed new keyboard Adding a new language keyboard -next release- Included in the next release labels Feb 12, 2022
@andrewtavis
Copy link
Member Author

Word counts via Data/check_language_data.sparql:

type total
adjective 1193
adverb 277
article 3
noun 7511
preposition 53
pronoun 46
proper noun 435
verb 3145

@andrewtavis andrewtavis added -priority- High priority and removed -next release- Included in the next release labels Feb 12, 2022
@ayushanand308
Copy link

@andrewtavis I want to work on this issue and I am new to this project. Can you share some resources on how to get started so that I can work on this issue?

@andrewtavis
Copy link
Member Author

Hey @ayushanand308! A big thing for this issue would be to have a good understanding of Wikidata Query Service so that we can make the queries for Danish a bit better — if needed :) The introduction to wikidata query service would be an initial place to look so that you can understand the use of SPARQL :)

Beyond that, could you let me know what experience you have with Swift, Python and Danish? No stress if your experience is limited! It looks like you have some Python experience, so that'll be great for doing the data formatting for the queries in Scribe-Data, and beyond that we can work a bit on whatever you'd like to learn 😊 If you're interested in learning Swift, we can work on that, or I can also handle that part of it if need be. Big question in those regards is are you an iOS or Android user? If you're Android, then maybe the issues you have picked in Scribe-Android would be a good focus, and then for iOS you can focus on the data part with your Python skills 🚀

Thanks for reaching out!

@ayushanand308
Copy link

@andrewtavis I would say I have an intermediate level in python and am constantly learning. No experience with swift or Danish. Would it be better for me to work on the English counterpart of this issue as I don't know any danish?

I am an android user. So I guess I would be going with what you have suggested i.e focusing on data part with python on the scribe's ios project and the issues that I have picked for the android project. :-)

@andrewtavis
Copy link
Member Author

Maybe working on the English counterpart would be better, @ayushanand308, but then we can probably figure out the Danish grammar ourselves for an MVP. This needs #96 to be finished to be viable anyway.

How about you focus on the Android issues for now and then we can switch back to this and you can work within Scribe-Data with your Python skills and maybe learn some SPARQL for Wikidata Query Service? Don't want to overload you right at the start :)

@ayushanand308
Copy link

@andrewtavis Ok. I will go that.

@andrewtavis
Copy link
Member Author

@ayushanand308, there are some simple tasks that you could do for Danish now, if you have interest. First and foremost adding a line to DAKeyboardViewController.swift that references the main view controller like the other KeyboardViewControllers for the other languages would be good, and then adding in the DAInterfaceVariables.swift and DACommandVariables.swift files would be good. You could use the Swedish files as a base and rename things where it should reference Danish rather than Swedish.

Happy to answer any questions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority help wanted Extra attention is needed new keyboard Adding a new language keyboard
Projects
Status: Todo
Development

No branches or pull requests

2 participants