Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo ImageData texture uploads #732

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adroitwhiz
Copy link
Contributor

Resolves

Resolves #731

Proposed Changes

This PR changes texImage2D calls back to being passed <canvas> elements directly rather than ImageData.

Reason for Changes

When uploading textures with premultiplied alpha, it's faster to pass in sources whose alpha is already premultiplied--see #731 for more detail.

Test Coverage

Should be tested manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading textures via ImageData is slower than doing it via regular images
1 participant